ensure that using the 'headers' option when creating a request returns the headers correctly when accessed #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the headers correctly when accessed
|
@antonmos, thank you for the PR. It looks good! I will merge and include in v1.4.1. For future reference, I would prefer separate PRs for separate issues (e.g. fix case sensitivity when using headers options and fix instructions for running test suite). I've updating the project's contribution guidelines to include this, but I haven't pushed it yet. So, my bad! This one is on me. :-) |
estilles
pushed a commit
that referenced
this pull request
Apr 14, 2015
ensure that using the 'headers' option when creating a request returns the headers correctly when accessed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, fix CONTRIBUTING.rd to explain how to run tests correctly.