Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change get_bucket to load only required bucket #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ibarria0
Copy link
Contributor

As of now get_bucket() calls _get_buckets(). This tries to get all the buckets for the API KEY. The problem with this is that for example in my case I provide clients with IAM keys that can only access their particular bucket, not all the buckets in my company's account. The method fails because it tries to list all buckets and it does not have permission.

There is no reason for get_bucket to try to get all the buckets in the account.

I've made changes so that it fetches only the bucket supplied by conf.json.

@ibarria0
Copy link
Contributor Author

I forgot to mention. This is an issue when upload to an s3 bucket and you only have access to the particular bucket, not every bucket of the account.

This is the case for when creating IAM users for clients that only have permissions for the client's particular bucket.

@ibarria0
Copy link
Contributor Author

ibarria0 commented May 5, 2016

Bumpy mc bumperton with bumpersauce......

@ibarria0
Copy link
Contributor Author

Ok, so... A bunch of tests fails because of the way the interaction with AWS is being tested. I'm gonna have to sit on this for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant