This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
ship config.yml to /usr/share and copy to user home ~/.calyptos #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how we use the config.yml. Instead of placing in /etc we will put it in /usr/share/calyptos/etc on install, then copy to ~/.calyptos in the user home dir when calyptos is executed.
| import shutil | ||
|
|
||
| dot_dir = os.path.expanduser('~/.calyptos') | ||
| default_cfgfile = os.path.join(dot_dir + "/" + "config.yml") |
There was a problem hiding this comment.
when using os.path.join its intended to be used as follows:
default_cfgfile = os.path.join(dot_dir, "config.yml")
Its functionality is to join add those /'s for you intelligently (ie removing duplicate /'s and such)
incorporate other PR comments from Vic: 1. use os.path.join properly 2. put config.yml in /usr/share/calyptos this also copies config.yml to the ~/.calyptos directory if there IS NOT a calyptos RPM package installed. this indicates that the user has used setup.py to install as opposed to rpm/yum, and we are allowing for the possibility that in a dev environment they may want to edit the config.
|
@viglesiasce I added your suggestions, they are in commit: Let me know what you think |
|
Thanks @mbacchi !!! |
viglesiasce
added a commit
that referenced
this pull request
Jun 9, 2015
ship config.yml to /usr/share and copy to user home ~/.calyptos
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we use the config.yml. Instead of placing in /etc
we will put it in /usr/share/calyptos/etc on install, then copy to
~/.calyptos in the user home dir when calyptos is executed.
@viglesiasce please also let me know if you prefer another way to call locate_cfgfile(), I'm not sure how these bootstrap type things are done in Python typically. Without a class to run an init() method I just stuck that method in main.