Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental options for PID in SD-JWT-VC #159

Conversation

babisRoutis
Copy link
Contributor

@babisRoutis babisRoutis commented May 15, 2024

This PR removes the various experimental options about issuing a PID in SD-JWT-VC.
Those options were related on how to selectively disclose composite claims like place_of_birth or address.

Now, such composite claims are made selectively disclosable recursively (early adoption of eu-digital-identity-wallet/eudi-doc-architecture-and-reference-framework#160)

Furthermore, a new composite claim is added age_equal_or_over

Closes #160

@babisRoutis babisRoutis requested a review from a team as a code owner May 15, 2024 18:56
@babisRoutis babisRoutis added the feature New feature or request label May 15, 2024
@babisRoutis babisRoutis added this to the pid-issuer v0.2.1 milestone May 15, 2024
@babisRoutis babisRoutis requested a review from dzarras May 15, 2024 18:57
dzarras
dzarras previously approved these changes May 16, 2024
@dzarras dzarras dismissed their stale review May 16, 2024 07:41

Question raised.

@babisRoutis babisRoutis merged commit 9aa2907 into eu-digital-identity-wallet:main May 16, 2024
3 checks passed
@babisRoutis babisRoutis deleted the fix/update-pid-in-sd-jwt-vc branch May 16, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove experimental options for PID in SD-JWT-VC
2 participants