Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated signing logic #99

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

dtsiflit
Copy link
Contributor

@dtsiflit dtsiflit commented Nov 25, 2024

Description of change

The BindingKey jwk case now accepts SigningKeyProxy instead of a SecKey as an associated value.
This is a breaking change and to continue using keys please use .secKey(your_key) instead of just your_key when creating a BindingKey.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dtsiflit dtsiflit marked this pull request as ready for review November 26, 2024 10:59
@dtsiflit dtsiflit requested a review from a team as a code owner November 26, 2024 10:59
@dtsiflit dtsiflit merged commit 18f4906 into eu-digital-identity-wallet:main Nov 26, 2024
2 checks passed
@dtsiflit dtsiflit deleted the SecureArea branch November 26, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants