Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential issuer id update #96

Conversation

dtsiflit
Copy link
Contributor

@dtsiflit dtsiflit commented Nov 4, 2024

Description of change

Updated CredentialIssuerId "from: Decoder" constructor to use all validations.

Addresses #93

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dtsiflit dtsiflit added the bug Something isn't working label Nov 4, 2024
@dtsiflit dtsiflit self-assigned this Nov 4, 2024
@dtsiflit dtsiflit requested a review from a team as a code owner November 4, 2024 08:17
@dtsiflit dtsiflit merged commit 56eca59 into eu-digital-identity-wallet:main Nov 4, 2024
3 checks passed
@dtsiflit dtsiflit deleted the feature/credential-issuer-id-construct branch November 4, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant