Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] added https check #69

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[fix] added https check #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/Entities/CredentialIssuer/CredentialIssuerId.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ public struct CredentialIssuerId: Codable, Equatable {

guard
let validURL = URL(string: string),
validURL.scheme == "https",
validURL.fragment == nil
else {
throw CredentialError.genericError
Expand Down
4 changes: 4 additions & 0 deletions Sources/Entities/IssuanceFlows/GetAuthorizationCodeURL.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ public struct GetAuthorizationCodeURL {
throw ValidationError.invalidUrl(urlString)
}

guard url.scheme == "https" else {
throw ValidationError.nonHttpsUrl(urlString)
}

let parameters = url.queryParameters
guard
parameters["\(Self.PARAM_CLIENT_ID)"] != nil
Expand Down
2 changes: 0 additions & 2 deletions Tests/Issue/GetAuthorizationCodeURLTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,12 @@ class GetAuthorizationCodeURLTests: XCTestCase {
}

func testInvalidURL() {
XCTExpectFailure()
XCTAssertThrowsError(try GetAuthorizationCodeURL(urlString: "invalid_url")) { error in
XCTAssertTrue(error is ValidationError)
}
}

func testNonHTTPSURL() {
XCTExpectFailure()
XCTAssertThrowsError(try GetAuthorizationCodeURL(urlString: "http://example.com?client_id=123")) { error in
XCTAssertTrue(error is ValidationError)
}
Expand Down
Loading