Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bearer authorization token spelling #51

Conversation

srosenda
Copy link
Contributor

@srosenda srosenda commented Jul 10, 2024

Description of change

The bearer prefix for the token should be spelled excactly as "Bearer", see https://datatracker.ietf.org/doc/html/rfc6750#section-2.1. The misspelled token was rejected by the Finnish EUDIWallet backend.

Fixes #52.

Implementation notes

Use TokenType.rawValue to produce string value of the token prefix to have the correct values defined in a single place.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Automated tests in this repository pass
  • The fixed token is accepted by the Finnish EUDIWallet backend

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

* It should be spelled excactly as "Bearer", see https://datatracker.ietf.org/doc/html/rfc6750#section-2.1
* Use TokenType.rawValue to produce string value of the token.
@srosenda srosenda force-pushed the fix/authorization-bearer-token-spelling branch from 3621acb to 84d42ef Compare July 10, 2024 15:14
@dtsiflit
Copy link
Contributor

Thank you for the PR @srosenda! We'll look at it over the next few days.

@srosenda
Copy link
Contributor Author

Thank you for the PR @srosenda! We'll look at it over the next few days.

You're welcome! FYI: I and most others in my team will be on vacation until beginning of August, so our replies to any feedback will take until there.

@dtsiflit dtsiflit merged commit ffa909e into eu-digital-identity-wallet:main Jul 16, 2024
2 checks passed
@dtsiflit
Copy link
Contributor

Thank you for the PR @srosenda! We'll look at it over the next few days.

You're welcome! FYI: I and most others in my team will be on vacation until beginning of August, so our replies to any feedback will take until there.

Same here :) I will look into this

Thank you for the PR @srosenda! We'll look at it over the next few days.

You're welcome! FYI: I and most others in my team will be on vacation until beginning of August, so our replies to any feedback will take until there.

No worries, same here :)

@srosenda srosenda deleted the fix/authorization-bearer-token-spelling branch August 1, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Bearer" authorization token prefix is misspelled in IssuanceAccessToken
2 participants