Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dpop-nonce format, use nonce in authorizeCode request in Issuer #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pankaj-sp
Copy link
Contributor

Description of change

I was getting error for invalid_dpop_proof as dpopNonce was not being passed in authorizeWithAuthorizationCode.
After making above fixes, it was still failing because of incorrect format of DPOP_NONCE_HEADER in Constant.swift file

Type of change

Please delete options that are not relevant.

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • [ x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • [ x ] My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dtsiflit
Copy link
Contributor

dtsiflit commented Jan 9, 2025

Thanks for this @pankaj-sp we'll review this over the next day or so. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants