Consistent Capitalization and Spelling Issues - 2nd Batch #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skounis
reviewed
Sep 5, 2024
|
|
||
| This project is licensed under the [Attribution 4.0 | ||
| International](http://creativecommons.org/licenses/by/4.0/) - see the | ||
| [LICENSE](https://github.com/eu-digital-identity-wallet/eudi-doc-architecture-and-reference-framework/blob/main/LICENSE) file for details. | ||
| [LICENCE](https://github.com/eu-digital-identity-wallet/eudi-doc-architecture-and-reference-framework/blob/main/LICENCE) file for details. |
There was a problem hiding this comment.
This update introducing a broken link and a 404 error. We if we keep this change we should also change the file name in the target repository
There was a problem hiding this comment.
The Licence file name has been updated from LICENSE -> LICENCE
commit
skounis
requested changes
Sep 5, 2024
There was a problem hiding this comment.
- Fix or schedule to fix the broken link this PR introduces
- Include changes relevant to Use consistent capitalization when referring to articles and sections. #177 and Mobile driving licence, display vs. present #131 or remove these two reference from the description of this PR
cc @duviner
This was
linked to
issues
Sep 6, 2024
2 tasks
2 tasks
The Licence file name must be changed from LICENSE -> LICENCE in accordance with the British English spelling rules.
skounis
approved these changes
Sep 6, 2024
update of the licence word inside the LICENCE file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the following issues: