Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back copy after merge #228

Closed
skounis opened this issue Jun 28, 2024 · 1 comment · Fixed by #231
Closed

Roll back copy after merge #228

skounis opened this issue Jun 28, 2024 · 1 comment · Fixed by #231

Comments

@skounis
Copy link
Contributor

skounis commented Jun 28, 2024

The PR #187 brings changes we approve except one. After we merge it we should take care of the following fix:

cc @digeorgi

@toonn
Copy link
Contributor

toonn commented Jun 28, 2024

As an explanation of my reasoning and to point out "that" can't be brought back without also removing the preceding comma.

The sentence at hand would become:

[Topic 25] and [Topic 26] (combined into one topic), present the current and foreseen status of the catalogues, their creation, distribution, discovery, management and maintenance, that will allow simple update procedures, ...

That is used to introduce a restrictive clause "will allow simple update procedures," and should therefore not be preceded by a comma. However, without the comma it is not clear what that ranges over and it seems to apply only to maintenance, "and (maintenance that will allow simple update procedures)."

My reading of the meaning is that everything summed up is what will allow for the simple update procedures, hence "their property 1, property 2 and property 3, will allow simple update procedures," though it is possible that the comma should still be removed.

skounis added a commit to skounis/architecture-and-reference-framework that referenced this issue Jun 28, 2024
digeorgi added a commit that referenced this issue Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants