Skip to content
This repository has been archived by the owner on Jun 13, 2020. It is now read-only.

WE NEED TESTS! #4

Open
RyanFrantz opened this issue May 5, 2014 · 2 comments
Open

WE NEED TESTS! #4

RyanFrantz opened this issue May 5, 2014 · 2 comments
Assignees
@RyanFrantz
Labels
enhancement tests

Comments

@RyanFrantz
Copy link
Contributor

We need tests! Lots of them.

  • Tests for the main code.
  • Tests for formatters, helpers, and messages.
  • Tests for anything I can't think of right now.
@RyanFrantz RyanFrantz self-assigned this May 5, 2014
@RyanFrantz
Copy link
Contributor Author

Looking at what lives in test/, we've got some work to do. That stuff is terribly outdated.

@RyanFrantz
Copy link
Contributor Author

Also, Test::Unit is deprecated. Look into MiniTest instead.

RyanFrantz pushed a commit that referenced this issue May 12, 2014
Wrote some initial tests.
7bd008f 
- Using Minitest as Test::Unit is deprecated.
- Wrote basic tests for the Executor class.
- For #4.
RyanFrantz pushed a commit that referenced this issue May 13, 2014
Tests for the Config module.
14ebf66 
- The Config tests forced me to update config.rb. Power.
- See #4.
RyanFrantz pushed a commit that referenced this issue May 16, 2014
Created shells for upcoming test methods.
eb0fb89 
- So much work to do but I'm headed to bed.
- Related to #4.
RyanFrantz pushed a commit that referenced this issue May 16, 2014
Lots of yummy tests for Formatter::Base.
79641a8 
- For #4.
RyanFrantz pushed a commit that referenced this issue May 16, 2014
Simplified how tests are run.
2bbae6f 
- Removed the older 'run_tests.rb' script and updated the Rakefile to call the new tests.
- For #4.
RyanFrantz pushed a commit that referenced this issue Jun 8, 2014
Added logging test.
c4aff77 
- Related to #4 and #12.
RyanFrantz pushed a commit that referenced this issue Jun 28, 2014
Added tests for the 'check_cpu' and 'check_memory' formatters.
44953d5 
- Related to #4.
- Cleaned up the 'check_cpu_idle.CRITICAL' environment file and added some missing output in the 'check_cpu' formatter.
RyanFrantz pushed a commit that referenced this issue Jul 3, 2014
Added tests for email messages.
4b8f77b 
- Refactored messages/email.rb a bit because #send was really building the message, then sending it.
- The message is built in #build_message which is called by #send, and then the message is delivered.
- This separates the concerns and makes it easier to write tests for this functionality.
- Related to #4.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RyanFrantz RyanFrantz

Labels
enhancement tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RyanFrantz