Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update es-restlog for ES 7.16.2 #6

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Update es-restlog for ES 7.16.2 #6

merged 5 commits into from
Jan 5, 2022

Conversation

etsymadho
Copy link
Contributor

@etsymadho etsymadho commented Dec 30, 2021

In addition to version update and jvm dependency update, there was an update for XContentHelper import for convertToJson call.

There was an change between version 7.15.2 and 17.16.x


version 7.15.2:
public static String convertToJson​(BytesReference bytes,
boolean reformatJson,
org.elasticsearch.common.xcontent.XContentType xContentType)

Reference: https://www.javadoc.io/doc/org.elasticsearch/elasticsearch/7.15.2/org/elasticsearch/common/xcontent/XContentHelper.html


version 7.16.2:
public static String convertToJson(BytesReference bytes,
boolean reformatJson,
org.elasticsearch.xcontent.XContentType xContentType)

Reference: https://www.javadoc.io/doc/org.elasticsearch/elasticsearch/7.16.2/org/elasticsearch/common/xcontent/XContentHelper.html

@cristi-
Copy link
Contributor

cristi- commented Dec 30, 2021

Can you also update the log4j version:

'org.apache.logging.log4j:log4j-api:jar:2.11.1',
to the version used by ES?
Thank you!

@etsymadho
Copy link
Contributor Author

WORKSPACE Show resolved Hide resolved
@cristi- cristi- requested a review from shikhar January 3, 2022 15:18
Copy link
Contributor

@cristi- cristi- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@etsymadho etsymadho merged commit 783fb09 into master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants