Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FileRegistry missing base_dir, if the model URI is local path #668

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Fix FileRegistry missing base_dir, if the model URI is local path #668

merged 3 commits into from
Jun 3, 2022

Conversation

eddyxu
Copy link
Collaborator

@eddyxu eddyxu commented Jun 3, 2022

No description provided.

@eddyxu eddyxu requested a review from changhiskhan June 3, 2022 05:13
@eddyxu
Copy link
Collaborator Author

eddyxu commented Jun 3, 2022

The test failure is the same as the one being fixed in #667.

Due to a minor python version bump (3.9.12 -> 3.9.13) making CI not able to find cached packages.

Will rebase after #667 is merged.

@eddyxu eddyxu merged commit 97eb333 into eto-ai:main Jun 3, 2022
@eddyxu eddyxu deleted the lei/fs_fixes branch June 3, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changhiskhan changhiskhan changhiskhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyxu @changhiskhan