Box2d label with Draw
#650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to set up the font size for text labels, but I found it complex, made it an independent issue. |
da-liii
reviewed
May 5, 2022
python/rikai/types/geometry.py
Outdated
| """ | ||
| # TODO add font size | ||
| return Draw( | ||
| [self, Text(text, (int(self.xmin), int(self.ymin)), color)] |
There was a problem hiding this comment.
as I suggested in #632 , we should shift the (xmin, ymin) like (xmin, ymin-10), and 10 should be the default height (or a bit bigger) of the font size
changhiskhan
reviewed
May 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #632, but extend
Drawinstead of using a list.It can have a sugar
which list hasn't.
part of #550