Update unit tests with act and clean up console #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffGreiner-eaton
requested review from
surajeaton and
ektaghag-eaton
as code owners
github-actions
bot
added
the
brightlayer-ui
|
Visit the preview URL for this PR (updated for commit e518925): https://blui-react-login--pr558-feature-blui-5380-up-jwu357at.web.app (expires Sun, 10 Mar 2024 20:47:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043 |
surajeaton
requested review from
huayunh,
joebochill,
aubreyhthompson,
manojleaton and
ArshdeepSingh3-eaton
|
still able to see these errors |
|
@ArshdeepSingh3-eaton any idea how to clean up the act() environment console warning? |
|
This is ready for review |
|
For the first time, it took too much time to run the test. But the second time I was able to run the test quickly. All console warnings are gone 👍 . |
ektaghag-eaton
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390.
Changes proposed in this Pull Request:
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?