Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User menu Item Translate #460

Merged
merged 1 commit into from
May 1, 2024

Conversation

priyankakmEaton
Copy link
Contributor

Fixes #5718

Changes proposed in this Pull Request:

  • Add translations to the user menu list items as per language.

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Apr 30, 2024
Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JeffGreiner-eaton
Copy link
Collaborator

any concerns with this here?
image

@ektaghag-eaton
Copy link
Contributor

any concerns with this here? image

Hi @JeffGreiner-eaton , I will fix this issue in another PR.

Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good

@priyankakmEaton priyankakmEaton merged commit ed70ac8 into release/R31 May 1, 2024
11 checks passed
@priyankakmEaton priyankakmEaton deleted the bug/5718_userMenuItemTranslate branch May 1, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

4 participants