Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow is unusable with soft keyboard #447

Merged

Conversation

manojleaton
Copy link
Contributor

@manojleaton manojleaton commented Apr 16, 2024

Fixes #BLUI-5536 .

Changes proposed in this Pull Request:

  • Added KeyboardAwareScrollView and WorkflowCardInstructions components in WorkflowCardBody

Screenshots / Screen Recording (if applicable)

Screenshot 2024-04-17 at 1 42 58 PM

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Apr 16, 2024
@JeffGreiner-eaton
Copy link
Collaborator

is there a way to keep the input field visible and not get pushed up under header?
image
image
image

  • create password screen seems good and inputs stay visible

@JeffGreiner-eaton
Copy link
Collaborator

On android I'm not able to see input fields
image
image

@ArshdeepSingh3-eaton
Copy link
Contributor

ArshdeepSingh3-eaton commented Apr 19, 2024

@JeffGreiner-eaton we have locked the orientation to portrait so Landscape orientation is not possible

@JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton we have locked the orientation to portrait so Landscape orientation is not possible

I'm confused why we would do this. We had the refactor of workflow card work here - #334

If landscape only works on tablet and not phones we need to document this
@joebochill

@JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton we have locked the orientation to portrait so Landscape orientation is not possible

I'm confused why we would do this. We had the refactor of workflow card work here - #334

If landscape only works on tablet and not phones we need to document this @joebochill

ok I miss understood layout for phone devices. We should add documentation on this and let our adopters know that landscape will not work on phone devices and document the "how to configure the application/routing to enforce that"

@manojleaton
Copy link
Contributor Author

@JeffGreiner-eaton we have locked the orientation to portrait so Landscape orientation is not possible

I'm confused why we would do this. We had the refactor of workflow card work here - #334

If landscape only works on tablet and not phones we need to document this @joebochill

It is already documented by @ArshdeepSingh3-eaton, please check routing.md
Had a discussion with @joebochill and he suggested to create a bug for this issue 450.

@manojleaton manojleaton merged commit 025f824 into release/R31 Apr 24, 2024
3 checks passed
@manojleaton manojleaton deleted the bug/5536-NewWorkflow-is-unusable-with-soft-keyboard branch April 24, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

3 participants