Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure the example project to use Open Sans font #386

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Configure the example project to use Open Sans font #386

merged 3 commits into from
Mar 15, 2024

Conversation

ArshdeepSingh3-eaton
Copy link
Contributor

Fixes # .
added OpenSans Font to Example Project
Update the text variant in verify code screen base

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Mar 12, 2024
surajeaton
surajeaton reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the goal was to update the variant only for Send Again button label.

Simulator Screenshot - iPhone 12 - 2024-03-13 at 16 15 37

@ArshdeepSingh3-eaton
Copy link
Contributor Author

ArshdeepSingh3-eaton commented Mar 14, 2024 •
edited
Loading

updated the code
Screenshot 2024-03-14 at 5 04 16 PM

@JeffGreiner-eaton
Copy link
Collaborator

looks good.

  • before
image
  • after
image

@ektaghag-eaton ektaghag-eaton merged commit d1b866a into release/R31 Mar 15, 2024
3 checks passed
@ektaghag-eaton ektaghag-eaton deleted the bug/BLUI-5467-FontAdded branch March 15, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffGreiner-eaton JeffGreiner-eaton JeffGreiner-eaton approved these changes

@manojleaton manojleaton Awaiting requested review from manojleaton

@ektaghag-eaton ektaghag-eaton Awaiting requested review from ektaghag-eaton

@joebochill joebochill Awaiting requested review from joebochill

@surajeaton surajeaton Awaiting requested review from surajeaton

Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArshdeepSingh3-eaton @JeffGreiner-eaton @surajeaton @ektaghag-eaton