Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create account full screen #362

Merged
merged 8 commits into from
Feb 28, 2024
Merged

create account full screen #362

merged 8 commits into from
Feb 28, 2024

Conversation

ArshdeepSingh3-eaton
Copy link
Contributor

@ArshdeepSingh3-eaton ArshdeepSingh3-eaton commented Feb 23, 2024 •
edited
Loading

Fixes # .

Changes proposed in this Pull Request:

  • ADD full Create Account Screen

Screenshots / Screen Recording (if applicable)

create-account

To Test:

  • in RegistrationProviderExample update the code to
    <RegistrationWorkflow> <CreateAccountScreen /> </RegistrationWorkflow>

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Feb 23, 2024
surajeaton
surajeaton reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error while clicking on next button:

Simulator Screenshot - iPhone 12 - 2024-02-26 at 15 54 08

@ArshdeepSingh3-eaton
Copy link
Contributor Author

Getting this error while clicking on next button:

Simulator Screenshot - iPhone 12 - 2024-02-26 at 15 54 08

fixed the issue

ektaghag-eaton
ektaghag-eaton reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All props are working fine 👍
Screenshot 2024-02-28 at 12 54 35 PM
Screenshot 2024-02-28 at 12 54 18 PM

login-workflow/src/screens/CreateAccountScreen/CreateAccountScreen.tsx Show resolved Hide resolved
login-workflow/src/screens/CreateAccountScreen/CreateAccountScreen.tsx Outdated Show resolved Hide resolved
@ektaghag-eaton
Copy link
Contributor

RTL and Dark Theme works fine 👍
Screenshot 2024-02-28 at 1 12 00 PM
Screenshot 2024-02-28 at 1 13 14 PM

@ektaghag-eaton ektaghag-eaton mentioned this pull request Feb 28, 2024
Merged
@ektaghag-eaton ektaghag-eaton self-requested a review February 28, 2024 10:45
@ArshdeepSingh3-eaton ArshdeepSingh3-eaton merged commit 6b8ec67 into release/R31 Feb 28, 2024
3 checks passed
@ArshdeepSingh3-eaton ArshdeepSingh3-eaton deleted the BLUI-5124-create-account-screen branch February 28, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajeaton surajeaton surajeaton left review comments

@ektaghag-eaton ektaghag-eaton ektaghag-eaton approved these changes

@manojleaton manojleaton Awaiting requested review from manojleaton

@JeffGreiner-eaton JeffGreiner-eaton Awaiting requested review from JeffGreiner-eaton

@joebochill joebochill Awaiting requested review from joebochill

Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArshdeepSingh3-eaton @ektaghag-eaton @surajeaton