Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add header #325

Merged
merged 6 commits into from
Feb 5, 2024
Merged

add header #325

merged 6 commits into from
Feb 5, 2024

Conversation

ArshdeepSingh3-eaton
Copy link
Contributor

Fixes # .

Changes proposed in this Pull Request:

  • Added WorkflowCardHeader component

Screenshots / Screen Recording (if applicable)

Screenshot 2024-01-30 at 3 51 24 PM

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 30, 2024
Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header is going up in tablet view(see below image)
Screenshot 2024-01-31 at 12 16 54 PM

Below changes are working fine
Screenshot 2024-01-31 at 12 17 14 PM

Screenshot 2024-01-31 at 12 31 16 PM

@JeffGreiner-eaton
Copy link
Collaborator

JeffGreiner-eaton commented Feb 1, 2024

maybe we can update the example in this PR or another one but can we use DrawerNavigationProp instead of StackNavigationProp for AppProps? it takes care of the typescript warning in the file....

image

import { DrawerNavigationProp } from '@react-navigation/drawer';

type AppProps = {
navigation: DrawerNavigationProp<RootStackParamList, 'WorkFlowCardExample'>;

<WorkflowCardHeader
title="Workflow Example"
...
onIconPress={(): void => {
navigation.navigate('Home');
}}

@JeffGreiner-eaton
Copy link
Collaborator

This seems ok.. but using textColor here also changes icon color by default?

image image

@JeffGreiner-eaton
Copy link
Collaborator

JeffGreiner-eaton commented Feb 2, 2024

looks good, are we able to update styles for larger devices mentioned above by @ektaghag-eaton?
Header / title to close to safe area...

image

image

Nexus android

image

Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts.

Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ektaghag-eaton ektaghag-eaton self-requested a review February 5, 2024 13:55
Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine.

@ektaghag-eaton ektaghag-eaton merged commit 1c1d786 into release/R31 Feb 5, 2024
3 checks passed
@ektaghag-eaton ektaghag-eaton deleted the feature/5098-WorkflowCardHeader branch February 5, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

4 participants