Feature/blui 5101 worflowcard actions #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…native-workflows into feature/blui-5101-worflowcard-actions
…native-workflows into feature/blui-5101-worflowcard-actions
ektaghag-eaton
requested review from
JeffGreiner-eaton,
surajeaton and
joebochill
as code owners
github-actions
bot
added
the
brightlayer-ui
surajeaton
reviewed
Jan 30, 2024
login-workflow/src/components/WorkflowCard/WorkflowCard.types.ts
Outdated
Show resolved
Hide resolved
login-workflow/src/components/WorkflowCard/WorkflowCardActions.tsx
Outdated
Show resolved
Hide resolved
surajeaton
reviewed
Jan 30, 2024
login-workflow/src/__tests__/components/WorkflowCard/WorkflowCardActions-test.tsx
Show resolved
Hide resolved
login-workflow/src/components/WorkflowCard/WorkflowCardActions.tsx
Outdated
Show resolved
Hide resolved
|
The component has been tested by passing all the props and it is working fine! |
|
Hi @surajeaton, please review again |
surajeaton
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 5101 .
Changes proposed in this Pull Request:
- Update JsDocs
- Write test cases with 80% coverage
- Update the demo in an example project to showcase the component.
- Update Readme
- Test in Dark / Light Theme
- Test It in RTL view
- Styling as per https://brightlayer-ui.github.io/patterns/forms#mobile
Screenshots / Screen Recording (if applicable)
To Test:
<WorkflowCardActions showPrevious showNext previousLabel="Back" nextLabel="Next" currentStep={2} totalSteps={5} divider onNext={()=>{ console.log('Next button clicked') }} onPrevious={()=>{ console.log('Previous button clicked') }} canGoNext={false} canGoPrevious={false} />Any specific feedback you are looking for?