Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example app #314

Merged
merged 5 commits into from
Jan 22, 2024
Merged

update example app #314

merged 5 commits into from
Jan 22, 2024

Conversation

ArshdeepSingh3-eaton
Copy link
Contributor

Fixes # .

Changes proposed in this Pull Request:

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 19, 2024
@ektaghag-eaton
Copy link
Contributor

Hi @ArshdeepSingh3-eaton, please take the latest pull from release/R31 to install husky on your local.

Copy link
Contributor

@ektaghag-eaton ektaghag-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-19 at 3 12 20 PM I am getting this error while running an example app in iOS. Do I need to re-install cocoapods?

@joebochill
Copy link
Collaborator

I am getting this error while running an example app in iOS. Do I need to re-install cocoapods?

This is related to this recent change for react-native 0.73.2. They changed the download location for boost (facebook/react-native#42180), and the new location appears to be blocked by IT. You may need to raise a ticket with IT to unblock it.

image

In the meantime, you can reverse the change mentioned in that issue since the original JFrog mirror appears to be back up and running.

@joebochill
Copy link
Collaborator

@ArshdeepSingh3-eaton version 6.9 of typescript-eslint introduced new configuration options for the naming-convention rule (added separate configuration options for default and imports). You can fix the errors by adding definitions to the "rules" entry (we should also do this at the root project level, or combine the lint configuration and have the root lint command also scan the example folder instead of having separate configs for the package and the example). Please also log an issue on the blui-code-standards repo for us to update to the lastest versions of ESLint and make this rule change.

The eslintrc file should look like:

module.exports = {
    root: true,
    parser: '@typescript-eslint/parser',
    extends: ['@brightlayer-ui/eslint-config/tsx'],
    parserOptions: {
        project: './tsconfig.json',
    },
+   plugins: ['react-hooks'],
+   rules: {
+       'react-hooks/rules-of-hooks': 'error', // Checks rules of Hooks
+       'react-hooks/exhaustive-deps': 'warn', // Checks effect dependencies
+       'react/display-name': 'off',
+       '@typescript-eslint/naming-convention': [
+           "error",
+           {
+               selector: 'default',
+               format: ['camelCase', 'PascalCase'],
+           },
+           {
+               selector: 'variable',
+               format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
+           },
+           {
+               selector: 'property',
+               format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
+           },
+           {
+               selector: 'property',
+               format: null,
+               modifiers: ['requiresQuotes'],
+           },
+           {
+               selector: 'enumMember',
+               format: ['UPPER_CASE'],
+           },
+           {
+               selector: 'parameter',
+               format: ['camelCase'],
+               leadingUnderscore: 'allow',
+           },
+           {
+               selector: 'memberLike',
+               modifiers: ['private'],
+               format: ['camelCase'],
+               leadingUnderscore: 'require',
+           },
+           {
+               selector: 'typeLike',
+               format: ['PascalCase'],
+           },
+           {
+              selector: 'import',
+               format: ['camelCase', 'PascalCase'],
+           },
+       ]
+   },
};

Copy link
Contributor

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example works fine and looks good.
Just fix the lint.

@surajeaton surajeaton merged commit e131774 into release/R31 Jan 22, 2024
1 check passed
@surajeaton surajeaton deleted the feature/BLUI-5138-new-Example branch January 22, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

4 participants