Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the CircleCI Build Pipeline for RN workflow #310

Merged
merged 11 commits into from
Jan 18, 2024

Conversation

JeffGreiner-eaton
Copy link
Collaborator

@JeffGreiner-eaton JeffGreiner-eaton commented Jan 15, 2024

Fixes Blui-5158.

Changes proposed in this Pull Request:

  • add step to install, prettier & lint
  • add step to test with parallelism: 4 & store test results
  • edit workflow to include test

Screenshots / Screen Recording (if applicable)

image
https://app.codecov.io/gh/etn-ccis/blui-react-native-workflows/tree/feature%2Fblui-5158-divide-build-steps/login-workflow%2Fsrc

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/R31@ecbfde6). Click here to learn what that means.

❗ Current head 4c8a9c8 differs from pull request most recent head f0783f7. Consider uploading reports for the commit f0783f7 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             release/R31     #310   +/-   ##
==============================================
  Coverage               ?   76.50%           
==============================================
  Files                  ?       27           
  Lines                  ?      383           
  Branches               ?       49           
==============================================
  Hits                   ?      293           
  Misses                 ?       62           
  Partials               ?       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeffGreiner-eaton JeffGreiner-eaton changed the base branch from dev to release/R31 January 15, 2024 19:22
@JeffGreiner-eaton JeffGreiner-eaton marked this pull request as ready for review January 16, 2024 12:59
@JeffGreiner-eaton JeffGreiner-eaton changed the title Feature/blui 5158 clean up the CircleCI Build Pipeline for RN workflow Clean up the CircleCI Build Pipeline for RN workflow Jan 16, 2024
project:
default:
target: 50%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target should be 80%.

@ektaghag-eaton ektaghag-eaton merged commit c611f64 into release/R31 Jan 18, 2024
3 checks passed
@ektaghag-eaton ektaghag-eaton deleted the feature/blui-5158-divide-build-steps branch January 18, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants