Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security/drop invalid headers #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Security/drop invalid headers #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f96057b
Add argument to loadbalancer to drop invalid headers
pdnt Apr 5, 2024
76d6d2e
Update deprecated argument from 'vpc' to 'domain'
pdnt Apr 5, 2024
8414528
Update deprecated bucket server-side encryption configuration
pdnt Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ resource "aws_lb" "app" {
subnets = var.enable_public_access ? [local.subnet_a_public_id, local.subnet_b_public_id] : [local.subnet_a_private_id, local.subnet_b_private_id]
security_groups = [aws_security_group.app.id]
idle_timeout = 300
drop_invalid_header_fields = true

tags = {
Name = "Etleap LB ${var.deployment_id}"
Expand Down
2 changes: 1 addition & 1 deletion nat.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ resource "aws_security_group_rule" "nat-ingress" {

resource "aws_eip" "nat" {
count = local.created_vpc_count
vpc = true
domain = "vpc"
}

resource "aws_eip_association" "nat" {
Expand Down
14 changes: 8 additions & 6 deletions s3.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@ resource "aws_s3_bucket" "intermediate" {
logging
]
}
}

server_side_encryption_configuration {
rule {
apply_server_side_encryption_by_default {
kms_master_key_id = var.s3_kms_encryption_key
sse_algorithm = var.s3_kms_encryption_key == null ? "AES256" : "aws:kms"
}
resource "aws_s3_bucket_server_side_encryption_configuration" "aws_s3_encryption" {
bucket = aws_s3_bucket.intermediate.id

rule {
apply_server_side_encryption_by_default {
kms_master_key_id = var.s3_kms_encryption_key
sse_algorithm = var.s3_kms_encryption_key == null ? "AES256" : "aws:kms"
}
}
}
Expand Down