Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for vectornav 100 #7

Merged
merged 12 commits into from
Mar 12, 2020
Merged

added support for vectornav 100 #7

merged 12 commits into from
Mar 12, 2020

Conversation

floriantschopp
Copy link
Contributor

No description provided.

@floriantschopp floriantschopp requested review from LBern and mfehr January 9, 2020 10:25
@mfehr
Copy link
Contributor

mfehr commented Jan 9, 2020

FYI @fmascarich

LBern
LBern requested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@LBern LBern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this! Here are some comments.

firmware/libraries/versavis/src/ADIS16445.cpp Outdated Show resolved Hide resolved
firmware/libraries/versavis/src/ADIS16448AMLZ.cpp Outdated Show resolved Hide resolved
firmware/libraries/versavis/src/ADIS16448AMLZ.cpp Outdated Show resolved Hide resolved
firmware/libraries/versavis/src/ADIS16460.cpp Outdated Show resolved Hide resolved
firmware/libraries/versavis/src/VN100.cpp Outdated Show resolved Hide resolved
firmware/libraries/versavis/src/ADIS16445.cpp Outdated Show resolved Hide resolved
@floriantschopp
Copy link
Contributor Author

@LBern Moved the whole IMU update to iterative 👍

rikba
rikba reviewed Jan 15, 2020
View reviewed changes
Copy link
Contributor

@rikba rikba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions/comments on the Serial part.

firmware/libraries/versavis/src/Imu.cpp Outdated Show resolved Hide resolved
firmware/libraries/versavis/src/VN100.cpp Show resolved Hide resolved
firmware/libraries/versavis/src/VN100.cpp Show resolved Hide resolved
firmware/libraries/versavis/src/VN100.cpp Outdated Show resolved Hide resolved
firmware/libraries/versavis/src/VN100.h Show resolved Hide resolved
firmware/libraries/versavis/src/VN100.h Show resolved Hide resolved
firmware/libraries/versavis/src/VN100.h Show resolved Hide resolved
firmware/libraries/versavis/src/versavis_configuration.h Outdated Show resolved Hide resolved
@rikba
Copy link
Contributor

rikba commented Jan 22, 2020 •
edited
Loading

Oh and can you add the addition of VN100 and the changes in the IMU driver to the changelog such as here https://github.com/ethz-asl/versavis/pull/3/files#diff-de0a9b67ffe2874a076b5fdb15bad484R1-R4? I think that would make the next release smoother.

LBern
LBern approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@LBern LBern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@floriantschopp
Copy link
Contributor Author

@floriantschopp Make uart wrapper work.

@floriantschopp floriantschopp mentioned this pull request Mar 12, 2020
Open
@floriantschopp floriantschopp merged commit fd69afa into master Mar 12, 2020
@floriantschopp floriantschopp deleted the feature/vn-100 branch March 12, 2020 10:33
@floriantschopp floriantschopp mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikba rikba rikba approved these changes

@LBern LBern LBern approved these changes

@mfehr mfehr Awaiting requested review from mfehr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@floriantschopp @mfehr @rikba @LBern