New Automatic Build and Push Actions #670
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflows have been rewritten to be slightly more modular.
There is still the test build action in
docker_build.yaml
which builds Kalibr in Ubuntu 16,18 and 20 and is triggered by any PR just like the old Build Actions.There is also a new push action in
docker_push.yaml
which builds and pushes the images to a registry. Currently, it builds both anamd64
as well asarm64
versions. This can easily be configured.At the moment it is pushed to my personal Docker Hub however, this can also easily be changed by modifying the
DOCKER_HUB_REPOSITORY
repository variable. Probably would be nice to have an ethz-asl or Kalibr Docker hub or use the GitHub Container Registry.The Push is only triggered by making a Release. I have noticed that Kalibr doesn't make releases, so this can easily be changed by triggering on a push to master.
All in all, this makes using Kalibr very simple without the need to compile anything:
docker run -it -v
pwd:/pwd mandulaj/kalibr:20.04
Or one can easily base their Dockerfile environments like this:
This is for sure work in progress, however, would be nice to integrate it.
We can for sure discuss modifying the final Registry location and form factor or adding some kind of Image versioning (although Kalibr doesn't really follow any versioning scheme).