Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

660 Add support for multiple statuses to be selected for filtering subject requests #802

Merged
merged 4 commits into from
Jul 5, 2022

Conversation

chriscalhoun1974
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 commented Jul 5, 2022

Purpose

Changes

660 - Add support for multiple statuses to be selected for filtering subject requests (#660)

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #
#660

chriscalhoun1974 and others added 2 commits July 5, 2022 13:02
… are importing a class of the same name from SQLAlchemy. Add type hinting to the view instead of the function called by the view to ensure that status is treated as a query param.

- Add a test for filtering on multiple statuses.
@chriscalhoun1974 chriscalhoun1974 marked this pull request as ready for review July 5, 2022 18:58
@chriscalhoun1974 chriscalhoun1974 changed the title 660 add support for multiple statuses 660 Add support for multiple statuses to be selected for filtering subject requests Jul 5, 2022
@pattisdr
Copy link
Contributor

pattisdr commented Jul 5, 2022

Only the migration-check test is failing which is a known error

@pattisdr pattisdr merged commit e9d044b into main Jul 5, 2022
@pattisdr pattisdr deleted the 660-add-support-for-multiple-statuses branch July 5, 2022 20:35
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants