This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
GET Available Connectors [#706] #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions and saas options.
- Add docs and postman collection.
pattisdr
changed the title
pattisdr
changed the title
pattisdr
commented
Jun 30, 2022
| conn_type.value | ||
| for conn_type in ConnectionType | ||
| if conn_type | ||
| not in [ConnectionType.saas, ConnectionType.https, ConnectionType.manual] |
There was a problem hiding this comment.
my assumption is that these types and the "custom" type below shouldn't be included in this list, that these are connectors that are available and ready to go
pattisdr
commented
Jun 30, 2022
|
|
||
| @router.get( | ||
| CONNECTION_TYPES, | ||
| dependencies=[Security(verify_oauth_client, scopes=[CONNECTION_TYPE_READ])], |
There was a problem hiding this comment.
I set scopes here but this may not be necessary
seanpreston
approved these changes
Jul 1, 2022
|
@ethyca/docs-authors Small docs addition added to the guides about how to see a list of available connector types |
10 tasks
conceptualshark
approved these changes
Jul 5, 2022
# Conflicts: # src/fidesops/schemas/saas/saas_config.py
|
fixing ClientDetail model import.. |
10 tasks
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Adds Saas type to saas yaml config * alter postman collection * updates changelog * lint fixes * Add endpoint to surface all available connectors including database options and saas options. * Exclude custom and manual types from list of available connectors. - Add docs and postman collection. * Update changelog. * Remove committed ANALYTICS_ID. * Import ClientDetail from fideslib instead of fidesops. * Fix import order. Co-authored-by: eastandwestwind <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Dependent on #706 - Merge that first
Purpose
As a Fidesops admin user, need the ability to see a list of available connector types to choose from so that I can select one to connect my fidesops environment to.
Changes
GET api/v1/connection_typeGET api/v1/connection_type?search=redChecklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #752