This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
659 Add Postgres and Redis to health endpoint #690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpreston
reviewed
Jun 22, 2022
def health_check() -> Dict[str, bool]: | ||
|
||
@router.get(HEALTH, response_model=Dict[str, Union[bool, str]]) | ||
def health_check() -> Dict[str, Union[bool, str]]: | ||
return { | ||
"healthy": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be great if we could change this response to "webserver": "healthy"
to standardise the format across the services. Or alternatively something like:
{
"healthy": True,
"db": {
"healthy": True
},
"cache": {
"healthy": True
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, I've updated to "webserver": "healthy"
seanpreston
suggested changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor ask to standardise the formats in the response, aside from that this is great
seanpreston
approved these changes
Jun 22, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* adds db and redis to health endpoint, untested * updates typing, suppresses sqlalchemy and alembic logs for healthchecks * adds to makefile, updates docs and tests * format * adds check for cache enabled, update tests * format * standardize health endpoint structure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds Postgres and Redis health checks to health endpoint.
Changes
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #659