-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
@pattisdr Looks good! I just finished my first pass and I have a few updates. The first is vertically centering the modal along with horizontally centering it. This will make it match the The second is to update the "Delete Connection" button to have a loading spinner while the delete is happening and then close the modal once the delete request is finished. The I also added some code that prevented the modal from closing while the request is happening example |
thanks for the review @TheAndrewJackson and pointing me towards some code examples 🏆 , I've responded to your comments. |
argh I forgot the "prevent modal from closing while request is happening" one moment EDIT: added below |
@TheAndrewJackson requested changes made, but I'm going to rebase this off of |
…ff of user delete modal.
…er successful deletion.
8ff5e3f
to
51f4842
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
* Link Delete Connection menu item with confirmation modal, patterned off of user delete modal. * Update changelog. * Vertically center modals. * Add a spinner while collection is being deleted. Only close modal after successful deletion. * Prevent closing modal while we're still making the delete request.
* Link Delete Connection menu item with confirmation modal, patterned off of user delete modal. * Update changelog. * Vertically center modals. * Add a spinner while collection is being deleted. Only close modal after successful deletion. * Prevent closing modal while we're still making the delete request.
❗ Dependent on #674, merge that first.
Purpose
Demonstrate that a user can delete a connected datastore from the Datastore Connection Management UI.
-- The datastore should be removed from the UI
-- When attempting to delete the connection, the user must be presented with a modal saying "Deleting a datastore connection may impact any subject request that is currently in progress. Do you wish to proceed?" (similar flow to deleting a user)
Changes
Delete intentionally slowed down to take 5 seconds here:
https://user-images.githubusercontent.com/9755598/174892119-5f50f174-c94b-4ce0-a5e9-0eb347a1b152.mov
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #604