This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Adds fidesops worker
command to start the Celery worker [#663]
#673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpreston
changed the title
663 fidesops worker
Adds Jun 24, 2022
fidesops worker
command to start the Celery worker [#663]
seanpreston
commented
Jun 24, 2022
sanders41
reviewed
Jun 27, 2022
sanders41
reviewed
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change in the Makefile will fix the docker-build
error. Everything else looks good.
- docker-build:
- docker build --tag $(IMAGE) .
+ docker-build:
+ docker build --tag $(IMAGE) -f Dockerfile.app .
sanders41
approved these changes
Jun 28, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* add fidesops worker cmd * rename Dockerfiles, adds worker specific dockerfile with no frontend * formatting * update container names, add separate dockerfile for worker * pass worker args through to worker_main * rename containers fidesops -> webserver, celery -> worker * fix imports * add return type * update dockerfile * describe changelog * specify same argv for all celery instantiation * add logging to cli * add back .egg * specify dockerfile to build from
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds some general Dockerfile hygiene and the
fidesops worker
which can serve as the entrypoint into thecelery
worker nodes.Changes
fidesops
towebserver
celery
toworker
redis
tocache
fidesops worker
click CLI command to bring up a workerChecklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #633