Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add AdminUiSettings to helper method #647

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Add AdminUiSettings to helper method #647

merged 4 commits into from
Jun 14, 2022

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jun 14, 2022 •
edited
Loading

Purpose

The log_all_config_values method is missing the admin ui settings. It should contain them.

Changes

  • Update log_all_config_values to display new admin ui settings

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review June 14, 2022 18:43
NevilleS
NevilleS approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Easy add

@TheAndrewJackson TheAndrewJackson merged commit ac09288 into main Jun 14, 2022
@TheAndrewJackson TheAndrewJackson deleted the 646_add_adminuisettings_to_helper_method branch June 14, 2022 19:22
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@TheAndrewJackson
Add AdminUiSettings to helper method (#647)
dad9e75 
* Add `AdminUiSettings` to helper method

* format code

* Update changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NevilleS NevilleS NevilleS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheAndrewJackson @NevilleS