This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
[SaaS Connector] Outreach (Erasures) #619
Merged
+173
−1
Merged
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
da0434e
Refactoring SaaS authentication in preparation for OAuth2
galvana a4c5e38
Formatting fixes
galvana c580312
Prepping new authentication module for merge with main
galvana 6877f31
Merge branch 'main' into 488-saas-connector-authentication-strategies
galvana 4002821
Adding missing class docstrings
galvana 27e2013
Formatting fix
galvana 69b3caa
Giving Segment more time for data to be available
galvana df8d2c3
Implementing PR recommendations
galvana 6d11225
Formatting fix
galvana 0160603
Fixing unit tests
galvana 8d0a17d
Fixing return type for assign_placeholders
galvana d242140
Reorganizing imports to avoid cyclic dependency
galvana c9d9993
Starting point for OAuth2 authentication strategy
galvana 4bec1b1
Adding mocks to OAuth2 strategy tests
galvana 6b3f757
Adding get_authorization_url to OAuth2 strategy
galvana cd38680
Adding authorization and OAuth2 callback endpoints
galvana 12417ca
Merge branch 'main' into 490-saas-connector-oauth2-authentication-str…
galvana 8b7bfc0
Adding tests for new API endpoints
galvana cb848c2
Fixing linter errors
galvana 19e6606
Fixing pylint and mypy errors
galvana 8112992
Fixing unit test
galvana 6440414
Fixing unit test
galvana d60fb00
Adding tests for scenarios without a refresh request and without an e…
galvana 7e05582
Fixing pagination tests
galvana 9f0b203
Fixing remaining pagination tests
galvana d641ded
Resolving merge conflict
galvana 10983cb
Starting point for Outreach connector
galvana 1caec91
First round of changes based on PR feedback
galvana 0f7a3b4
Passing in db session where possible
galvana 88a20c6
Fixing type hints
galvana 89508be
Fixing type hints
galvana 5514472
Merge branch 'main' into 490-saas-connector-oauth2-authentication-str…
galvana 201a7d1
Fixing down_revision
galvana cd74c12
Merge branch '490-saas-connector-oauth2-authentication-strategy' into…
galvana 04566fc
Adding "exact" and "case_sensitive" options to filter post-processor
galvana 55b1bf9
Merge branch '583-saas-connectors-extend-filter-post-processor' into …
galvana dc33d5d
Updating changelog
galvana 52645e4
Simplifying instance check
galvana 31c20ff
Fixing unit test
galvana ec01ffb
Merge branch '583-saas-connectors-extend-filter-post-processor' into …
galvana 95769fe
Dataset and access config for Outreach
galvana 44755b0
Updating collection names
galvana 7261e64
Updating changelog
galvana ba2f3e7
Merge branch 'main' into 255-saas-connector-outreach
galvana 99a84e7
Starting point for Outreach erasures
galvana 69a3e02
Adding erasure requests for prospects and recipients
galvana 8c6fd64
Merge branch '255-saas-connector-outreach' into 618-saas-connector-ou…
galvana 7bc412c
Merge branch 'main' into 618-saas-connector-outreach-erasure
galvana 30183f0
Reverting incorrect changelog updates
galvana 412580f
Too far
galvana 7a22c1c
Updating changelog
galvana a2416af
Update saas_config.toml
galvana d68f068
Merge branch 'main' into 618-saas-connector-outreach-erasure
galvana d077d08
Skipping test for erasures
galvana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -169,6 +169,7 @@ class ConnectorParam(BaseModel): | |
"""Used to define the required parameters for the connector (user-provided and constants)""" | ||
|
||
name: str | ||
description: Optional[str] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding this to include descriptions for fields that need more of an explanation than what can just be assumed from the name alone. Currently there is no additional logic in Fidesops that makes use of this information but this could be helpful when for when we have a UI to create/manage SaaS configs. |
||
|
||
|
||
class SaaSConfig(BaseModel): | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In YAML the pipe
|
is used to indicate a "block scalar" value (multiline text). This allows us to denote JSON payloads inline with YAML while avoiding having to escape single or double quotes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's cool, good thing i got to review this PR and learn something new :)