-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
I believe we'll have to implement a "deep equality" check, like: class Something:
def __eq__(self, other):
return self.__dict__ == other.__dict__ |
The version of black that was pinned turned out to be incompatible with the newer version of Click so I'm bumping that also. |
Thanks @PSalant726, I tried this initially and it didn't work, but I only did it at the last level and not the nested classes also. I'm thinking now maybe it will work if I take it all the way down the chain. |
Adding |
boto3~=1.18.14 | ||
click==7.1.2 | ||
click==8.1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the secret to getting this to pass? I struggled with this yesterday
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like black
was also bumped to v22.3.0 in ada24f8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did have issues with black
and the older version of click
so that may be it.
* Bump fastapi dependencies * Bump black 21.8b0 to 22.3.0 and format files * Add __eq__ methods to classes Co-authored-by: Paul Sanders <[email protected]>
Purpose
Bumps FastAPI and FastAPI's dependencies to allow installing fideslib.
There are 2 failing tests, test_generate_field and test_field_collect_matching after updating the dependencies. The dependency causing an issue is Pydantic. Both tests are failing for the same reason. They are comparing two objects with nested objects for equality. In older versions of Pydantic, the nested objects were created with pointers so the equality test would pass because the objects were at the same memory address. Now Pydantic creates the objects by creating new instances of the objects. Because of the, even though the values contained in the objects are the same, the tests fail because the test object id's are no longer the same. Any suggestions on getting around this?
Changes
fastapi[all]
removed from requirements.txtChecklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #