Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Check tests/ directory in black-ci command #594

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jun 3, 2022

Purpose

Update black-ci command to also check tests/ directory. This will align it with the black command that formats both src/ and tests/

Changes

  • Update black-ci to also check tests/
  • Simplify both black commands

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #593

@TheAndrewJackson TheAndrewJackson changed the title Check tests in black-ci Check tests/ directory in black-ci command Jun 3, 2022
@seanpreston seanpreston self-assigned this Jun 3, 2022
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review June 3, 2022 19:01
@sanders41 sanders41 merged commit 987beb1 into main Jun 3, 2022
@sanders41 sanders41 deleted the 593_check_tests branch June 3, 2022 19:04
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* Check tests in black-ci

* Update changelog

* Simplify black commands
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

black-ci command does not check tests/
3 participants