This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Cache/Surface Resume/Restart Privacy Request Details [#574] #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattisdr
force-pushed
the
fidesops_570_surface_resume_instructions
branch
2 times, most recently
from
June 6, 2022 20:14
edb55d5
to
057930a
Compare
…ta. The manual connector is probably not a SQL database, but it's a pretty readable way to surface what needs to be performed manually. The actually format will probably change. - To the privacy request status endpoint, surface the stopped step, stopped collection, manual queries, and resume endpoint for paused or failed privacy requests.
…uest execution to store all details under the same key: the step, the collection, and any action needed to resume. - Add a ManualQueryConfig - Get rid of using the SQLQueryConfig to cache queries, instead opt to store these in a more generic way for later flexibility.
…e now caching more generic components.
…a manual collection. - Start setting finished_processing_at on errored privacy requests that fail due to a collection issue.
pattisdr
force-pushed
the
fidesops_570_surface_resume_instructions
branch
from
June 7, 2022 16:19
28f14d3
to
8d039d5
Compare
pattisdr
changed the title
Surface Resume/Restart Instructions [#574]
Cache/Surface Resume/Restart Privacy Request Details [#574]
Jun 8, 2022
pattisdr
commented
Jun 8, 2022
…resume_instructions # Conflicts: # CHANGELOG.md
sanders41
reviewed
Jun 8, 2022
thanks for taking the time to review @sanders41! I believe I've addressed your comments. |
@ethyca/docs-authors I've added a docs draft for how to view details on how to resume or restart your paused and failed privacy requests to the guides. |
sanders41
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
conceptualshark
approved these changes
Jun 9, 2022
10 tasks
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* WIP Cache SQL queries for the manual connector for retrieve/update data. The manual connector is probably not a SQL database, but it's a pretty readable way to surface what needs to be performed manually. The actually format will probably change. - To the privacy request status endpoint, surface the stopped step, stopped collection, manual queries, and resume endpoint for paused or failed privacy requests. * Add unit tests asserting expected response for paused/failed privacy requests. * Refactor caching details about the collection that halted privacy request execution to store all details under the same key: the step, the collection, and any action needed to resume. - Add a ManualQueryConfig - Get rid of using the SQLQueryConfig to cache queries, instead opt to store these in a more generic way for later flexibility. * Get rid of elements that cache a SQLQuery from an earlier draft. We're now caching more generic components. * Remove import of element that no longer exists. * Add new paused_at field for when a request is paused by a webhook or a manual collection. - Start setting finished_processing_at on errored privacy requests that fail due to a collection issue. * Small docstring changes. * Add changelog and docs. * Respond to CR - * Fix wording in docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Contains migration; check downrev before merging
Purpose
In the event of a paused or failed privacy request, surface to the user how to resume/restart that request.
Changes
A GET /privacy_request/?request_id=<privacy_request_id> now returns something like:
A request that needs erasure input looks like this:
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #570