Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Update PR checklist for CHANGELOG.md #558

Merged
merged 4 commits into from
May 25, 2022
Merged

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented May 25, 2022

Purpose

Update the CHANGELOG.md instructions to be more clear.

Changes

  • Add new checklist items for updating the CHANGELOG.md
  • Add missing PR link from a previous merge

Checklist

  • Update CHANGELOG.md file in appropriate sections
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #535

@TheAndrewJackson TheAndrewJackson changed the title Update PR checklist for CHANGELOG Update PR checklist for CHANGELOG.md May 25, 2022
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements here @TheAndrewJackson

@pattisdr pattisdr merged commit 050ac85 into main May 25, 2022
@pattisdr pattisdr deleted the 535_update_PR_checklist branch May 25, 2022 17:39
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update changelog PR checklist item
2 participants