Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

MySQL for M1 Chips #54

Merged
merged 1 commit into from
Nov 12, 2021
Merged

MySQL for M1 Chips #54

merged 1 commit into from
Nov 12, 2021

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Nov 9, 2021

Purpose

Users with M1 chips when running integration tests locally get the error: docker: no matching manifest for linux/arm64/v8 in the manifest list entries because the MySQL image doesn't support arm64 architecture.

Changes

  • For MySQL, add --platform linux/amd64 to run an Intel image under emulation

From Docker Desktop for Apple silicon

Not all images are available for ARM64 architecture. You can add --platform linux/amd64 to run an Intel image under emulation. In particular, the mysql image is not available for ARM64. You can work around this issue by using a mariadb image.

  • Get rid of the extra docker-compose file created specifically for quickstarts since the primary integration-test docker-compose file can be used - this also opens up the quickstart to be able to be used with mysql too.

To test

Run make pytest-integration-access locally - should work for both M1 and intel chips.

Ticket

[No ticket]

@pattisdr
Copy link
Contributor Author

pattisdr commented Nov 9, 2021

Reopened from #25 to be a PR from this repo instead of my fork, while we don't have CI enabled for forks.

@pattisdr pattisdr mentioned this pull request Nov 9, 2021
@pattisdr
Copy link
Contributor Author

pattisdr commented Nov 9, 2021

^ Approved by Phil in #25

Copy link
Contributor

@PSalant726 PSalant726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that make pytest-integration-access can run completely on my 2020 M1 MacBook Pro, but I'm seeing intermittent test failures that I wasn't seeing on @pattisdr 's fork. They're all re: Mongo, so probably unrelated to these changes?

@pattisdr
Copy link
Contributor Author

thanks @PSalant726 this is unrelated, I occasionally get these mongo timeout errors locally too, usually rerunning fixes, we might need to make the mongo connection more reliable.

Do you mind going ahead and merging when you're done?

@PSalant726 PSalant726 merged commit dc72d96 into main Nov 12, 2021
@PSalant726 PSalant726 deleted the mysql-m1 branch November 12, 2021 22:05
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants