This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
remove absolute path dependencies in tests [#50] #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
There was a problem hiding this comment.
Just 2 nits, otherwise good to go. Nice work figuring out this path issue! Here's the follow-up ticket for documentation- #52
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* remove absolute path dependencies in tests * fixed method doc on load order * minor cleanup Co-authored-by: Steven Benjamin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some fixtures contain absolute paths (e.g. for data files). This means they only run from the project root, and individual tests won't run from e.g. pycharm which runs from the current working directory.
Changes
Refactor config to share a
load_filemethod that searchesTicket
50