Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

[Misc] Adds user data to the login response #501

Merged
merged 1 commit into from
May 12, 2022
Merged

[Misc] Adds user data to the login response #501

merged 1 commit into from
May 12, 2022

Conversation

seanpreston
Copy link
Contributor

Purpose

The Admin UI needs awareness of the logged in user's ID in order to make certain API requests that require the user's ID.

Changes

  • Adds user_data to the UserLoginResponse, alongside token_data.

Checklist

  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

@LKCSmith LKCSmith mentioned this pull request May 12, 2022
Merged
6 tasks
eastandwestwind
eastandwestwind approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@eastandwestwind eastandwestwind merged commit 2508870 into main May 12, 2022
@eastandwestwind eastandwestwind deleted the add-user-data-to-login branch May 12, 2022 16:35
adamsachs pushed a commit to adamsachs/fidesops_forked_test that referenced this pull request May 17, 2022
adds user data to the login response (ethyca#501)
e816c05
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
adds user data to the login response (#501)
d558f7e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees

@eastandwestwind eastandwestwind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanpreston @eastandwestwind @TheAndrewJackson