Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

[#396] Frontend for Privacy Request denial flow #480

Merged
merged 9 commits into from
May 12, 2022

Conversation

TheAndrewJackson
Copy link
Contributor

Purpose

Update the FE to use the denial reason audit logs that were added in #397

Changes

  • Update the Deny Privacy Request button to pull up a modal that allows a user to enter a denial reason

Checklist

  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #396

Copy link
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to spin-up any mock subject (privacy?) requests locally to test this out, so this is purely a code review.

@seanpreston seanpreston changed the title 396 FE deny subject request [#396] Frontend for Privacy Request denial flow May 10, 2022
@LKCSmith LKCSmith merged commit 641e82a into main May 12, 2022
@LKCSmith LKCSmith deleted the 396_FE_deny_subject_request branch May 12, 2022 14:27
adamsachs pushed a commit to adamsachs/fidesops_forked_test that referenced this pull request May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Admin UI] FE - Ability to input a reason for denying a Subject Request
3 participants