This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
[#446] Adds first_name, last_name, created_at to FidesopsUser response
#465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAndrewJackson
approved these changes
May 5, 2022
| response_body = json.loads(response.text) | ||
| assert HTTP_201_CREATED == response.status_code | ||
| assert response_body == {"id": user.id} | ||
| assert user.permissions is not None |
There was a problem hiding this comment.
It might be good to also assert that the users first_name and last_name are what they were set to when it was created. There are test cases below that check those fields so it is tested indirectly.
There was a problem hiding this comment.
I've worked out why that's happening. We're explicitly running black /src in the Makefile. Will follow-up this change as part of a subsequent hotfix.
6 tasks
adamsachs
pushed a commit
to adamsachs/fidesops_forked_test
that referenced
this pull request
May 17, 2022
…sUser` response (ethyca#465) * add fixture for user, add first_name and last_name to FidesopsUser, add fields to response * run autoformatter on migrations * make username unique, rename fixture * test multiple user get endpoint
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
… response (#465) * add fixture for user, add first_name and last_name to FidesopsUser, add fields to response * run autoformatter on migrations * make username unique, rename fixture * test multiple user get endpoint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The frontend requires these fields for interface display purposes.