This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Remove unused import #347
Merged
Remove unused import #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattisdr
reviewed
Apr 15, 2022
| @@ -1,8 +1,7 @@ | |||
| from typing import Any, Dict | |||
There was a problem hiding this comment.
🔍 good attention to detail! looks like we're ignoring missing imports in mypy for some reason
adamsachs
pushed a commit
to adamsachs/fidesops_forked_test
that referenced
this pull request
May 17, 2022
* Remove unused import * Add health url to urn_registry.py
sanders41
added a commit
that referenced
this pull request
Sep 22, 2022
* Remove unused import * Add health url to urn_registry.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Removes the unused
Anyimport inhealth_endpoints.pyChanges
I also noticed there was not a test for the health endpoint so I added one to make sure things still worked after removing the import.
Checklist
Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external services