This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
[SaaS Connector] SaaS fixture cleanup #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st_params-to-reference-connector_param-values
…lect the confidential nature of the values
…st_params-to-reference-connector_param-values
seanpreston
reviewed
Mar 31, 2022
| params={}, | ||
| body=json.dumps(member), | ||
| ) | ||
| connector.create_client().send(request) |
There was a problem hiding this comment.
This is awesome, thanks @galvana
seanpreston
reviewed
Mar 31, 2022
| path: str = self.assign_placeholders(current_request.path, param_values) | ||
|
|
||
| headers: Dict[str, Any] = {} | ||
| for header in current_request.headers or []: |
There was a problem hiding this comment.
There's a case to say we should update SaaSRequest to have sane defaults as opposed to optional values. That way we'd not need to make these or [] checks for instance. It's not something that ought to happen here. What do you think?
seanpreston
approved these changes
Mar 31, 2022
galvana
added
run unsafe ci checks
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
Separating SaaS example and Mailchimp fixtures Co-authored-by: Adrian Galvan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To separate the
saas_examplesetup used for unit tests from the rest of the SaaS fixtures. The new Mailchimp fixtures also serve as an example for other SaaS integration tests.Addresses a comment from an earlier ticket.
#278 (comment)
Changes
Checklist
Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external services