-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've been knocking out a ton of db connections lately 💪 @eastandwestwind!
A few mariadb requests not related to specific lines in this PR:
- Can you update the mariadb port in the postman collection?
- Consider adding a
SQLConnector.legacy_cursor_result_to_rows
method that you can call fromcursor_result_to_rows
in MySQL, MariaDB, and MSSQL, now that we've duplicated that logic in several places. - When I run
make integration-env
, and the MariaDB database comes up, I see it running2022-02-09 15:27:48+00:00 [Note] [Entrypoint]: /usr/local/bin/docker-entrypoint.sh: running /docker-entrypoint-initdb.d/mariadb_example.sql
in the mariadb logs, but it doesn't look like there's any data in the MariaDB database - a local privacy request doesn't turn up any data there.
I didn't realize that this branch wasn't up-to-date with main and your port change at first, so I did try bringing it up with the bad port to start, that may have affected things, but can you take a look?
Thanks for the review!
|
looks good @eastandwestwind! thanks for letting me know how we were planning on testing this in the future. looks like Sean is adding some steps to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes!
Purpose
Adds support for MariaDB query execution
Changes
Checklist
Ticket
Fixes #79