-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @eastandwestwind, well-organized, easy to follow, just a few changes requested ⭐
Thanks for the comments @pattisdr ! Ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful @eastandwestwind!
More of a general comment, related to Sean's testing work, it will be good when we are testing each datastore against every data type; we may be missing datastore-specific handling in places. But this PR definitely demonstrates basic MySQL access/erasures in line with how we introduced the other datastores and we can continue to improve our test matrix. Thanks again for adding MySQL to the postman collection!
Purpose
Adds query execution support for MySQL Connector.
Changes
LegacyCursorResult
return type from SQLAlchemy.Checklist
Ticket
Fixes #136