-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
…ration connection tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work @eastandwestwind - the main additional piece I'd like to see is to try to get the mssql_example database created and populated when we run make integration-env
, not just creating it in the integration tests
Ok, @pattisdr , over to you again! I cleaned up the PR based on your suggestions, and was able to get logs to print for I also reused the |
great will take a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @eastandwestwind 🏆 - i really liked your solution to bring up the docker containers in detached mode, then exec into the fidesops container to run the python mssql initialization script to get around the M1 + MSSQL issues when we're trying to create a test mssql_example
database on make integration-env
.
just one quick point and I think this is good to go
engine.execute(sqlalchemy.sql.text(query)) | ||
|
||
|
||
mssql_setup() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to only call this if we're running this file directly (which will set the __name__variable as __main__
) and not call this when we import it:
if __name__ == "__main__":
mssql_setup()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh I see, good catch!
Co-authored-by: Dawn Pattison <[email protected]> Co-authored-by: catherinesmith <[email protected]> Co-authored-by: Catherine Smith <[email protected]>
Purpose
Adds SQL Server support
Changes
PUT
{{host}}/connection/{{mssql_key}}/secret
, use the following url:"mssql+pyodbc://sa:Mssql_pw1@mssql_example:1433/mssql_example?driver=ODBC+Driver+17+for+SQL+Server"
, alternatively you can break each part out into separate components, refer toconnection_secrets_mssql.py
.Checklist
Ticket
Fixes #78