-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
src/fidesops/main.py
Outdated
"Fidesops has been deprecated. The codebase has merged into the Fides repo. Located at " | ||
"https://github.com/ethyca/fides" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current warning message wording is mainly here to serve as a starting point. Do you either @seanpreston or @ThomasLaPiana any specific wording you'd prefer over what is currently there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe also link to the docs site? we don't have the official migration guide up yet to link to unfortunately, but I think having links to both would be helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wording works for me. Adding something to the README and docs is necessary too. @conceptualshark do you have any opinions here?
@TheAndrewJackson thanks for tackling this! |
@TheAndrewJackson / @ThomasLaPiana I was thinking we might also want to label the repository too, or at least update the README and description. |
@seanpreston I might be wrong here (@NevilleS can confirm) but I think we're going to private it? At least I assumed that was the ultimate goal |
That'd make sense to move it to private, or archived/similar. Let's wait a month or two though, we've got other things to focus on first 👍 |
@NevilleS Does updating the readme and repo labels makes sense since the archival won't happen for a month or two? |
@seanpreston It looks like I may not have permission to update the repo description and labels. Could you do that? |
Purpose
Add a deprecation warning to let users know that the Fidesops repo is no longer being developed and lets them know where to go instead. Currently it only logs the warning on startup but the warning could logged more frequent if desired.
Changes
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1422