This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Specify Multiple Masking Strategies #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-compatible way. Pass in one or more strategies under "masking_strategy", either as a single strategy or a list of strategies. If a list is supplied, the strategies will be applied in the same order as the list.
|
@ethyca/docs-authors Adding this PR in fidesops instead of fides after talking to Sean - sounds like there may be another release - Small docs changes around using fides as a masking engine |
…le - it still needs to be a Dict with string keys, but the values are much more open. This supports other masking strategies with more complex configurations.
seanpreston
reviewed
Oct 17, 2022
| ) | ||
| masked_values = strategy.mask(values, None) | ||
| values = request.values or [] | ||
| masked_values: Optional[List[Any]] = request.values.copy() |
There was a problem hiding this comment.
Should this be optional? It looks like it might always be an empty list if nothing else?
There was a problem hiding this comment.
yes I agree with you, I was getting "Incompatible types in assignment" mypy errors because masking.mask is allowed to take in None. I think we should instead ignore the type hint error then when we call masking.mask
seanpreston
reviewed
Oct 17, 2022
seanpreston
reviewed
Oct 17, 2022
|
👍 Looks good on the docs front, thank you! |
…_masking_strategies # Conflicts: # CHANGELOG.md
|
thanks for reviewing @conceptualshark 😄 |
|
Made some type adjustments @seanpreston back to you! |
9 tasks
pattisdr
added a commit
to ethyca/fides
that referenced
this pull request
Nov 1, 2022
…l/1428 to allow multiple masking strategies to be specified when using fides as a masking engine.
NevilleS
pushed a commit
to ethyca/fides
that referenced
this pull request
Nov 1, 2022
* add redis settings fix * Copy and paste over the work inhttps://github.com/ethyca/fidesops/pull/1428 to allow multiple masking strategies to be specified when using fides as a masking engine. * Consolidate multiple Fixed headings, and update Changelog with the redis db index and the multiple masking strategies changes. Co-authored-by: Dawn Pattison <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allow multiple masking strategies to be specified when using fides as a masking engine.
Changes
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes https://github.com/ethyca/fidesops-plus/issues/74